Skip to content

Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737)#18737

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
SS-JIA:export-D99707657
Apr 17, 2026
Merged

Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737)#18737
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
SS-JIA:export-D99707657

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Apr 7, 2026

Summary: Pull Request resolved: #18737

Differential Revision: D99707657

@SS-JIA SS-JIA requested a review from robert-kalmar as a code owner April 7, 2026 14:34
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18737

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 651e4f4 with merge base 107eb92 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 7, 2026

@SS-JIA has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99707657.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA
Copy link
Copy Markdown
Contributor Author

SS-JIA commented Apr 7, 2026

@robert-kalmar There are efforts within Meta to upgrade to new numpy versions; it seems that some changes in the NXP backend will be needed for this. Just want to check with you guys if the changes make sense.

@meta-codesync meta-codesync Bot changed the title Upgrade fbcode/executorch to Python Scientific Stack 3 Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737) Apr 8, 2026
@SS-JIA SS-JIA force-pushed the export-D99707657 branch from 19d5d09 to a9c825f Compare April 8, 2026 16:51
SS-JIA pushed a commit to SS-JIA/executorch-1 that referenced this pull request Apr 8, 2026
Summary: Pull Request resolved: pytorch#18737

Differential Revision: D99707657
SS-JIA pushed a commit to SS-JIA/executorch-1 that referenced this pull request Apr 8, 2026
Summary: Pull Request resolved: pytorch#18737

Differential Revision: D99707657
@SS-JIA SS-JIA force-pushed the export-D99707657 branch from a9c825f to 88bfcad Compare April 8, 2026 16:55
@robert-kalmar
Copy link
Copy Markdown
Collaborator

robert-kalmar commented Apr 9, 2026

@robert-kalmar There are efforts within Meta to upgrade to new numpy versions; it seems that some changes in the NXP backend will be needed for this. Just want to check with you guys if the changes make sense.

@SS-JIA, understand. The changes are legit. It is only Meta internal upgrade, or OSS ExecuTorch too? This PR contains just the update for the API used to NUMPY, but not the numpy version - https://github.com/pytorch/executorch/blob/main/pyproject.toml . Is the intention is allow both numpy 2.x and 3x or the update is just split into multiple PRs?

FYI, such a PR was already opened by @rascani #16714 some time ago, but not merged.

@SS-JIA SS-JIA force-pushed the export-D99707657 branch from 88bfcad to e6832a7 Compare April 17, 2026 18:41
pytorch-bot Bot pushed a commit that referenced this pull request Apr 17, 2026
Summary: Pull Request resolved: #18737

Differential Revision: D99707657
SS-JIA pushed a commit to SS-JIA/executorch-1 that referenced this pull request Apr 17, 2026
Summary: Pull Request resolved: pytorch#18737

Differential Revision: D99707657
@SS-JIA SS-JIA force-pushed the export-D99707657 branch from e6832a7 to a9dd9da Compare April 17, 2026 18:44
Summary: Pull Request resolved: pytorch#18737

Differential Revision: D99707657
@SS-JIA SS-JIA force-pushed the export-D99707657 branch from a9dd9da to 651e4f4 Compare April 17, 2026 18:54
@meta-codesync meta-codesync Bot merged commit 99d1756 into pytorch:main Apr 17, 2026
418 of 425 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants